Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(INFRANG-6623): Update golang.mk #178

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

n0rtr0n
Copy link
Contributor

@n0rtr0n n0rtr0n commented Dec 18, 2024

JIRA:
https://clever.atlassian.net/browse/INFRANG-6623

Updating golang.mk to latest version.

This change disables CGO builds by default, and creates two separate targets for CGO and debug builds.

Build produced with updated golang.mk

@n0rtr0n n0rtr0n marked this pull request as ready for review December 19, 2024 05:04
@n0rtr0n n0rtr0n requested a review from a team as a code owner December 19, 2024 05:04
@n0rtr0n n0rtr0n requested review from jakegut and removed request for a team December 19, 2024 05:04
@n0rtr0n
Copy link
Contributor Author

n0rtr0n commented Jan 13, 2025

@jakegut Thank you for approving this PR! Feel free to merge at your convenience so that you have more control over any deploys that may be necessary.

@n0rtr0n
Copy link
Contributor Author

n0rtr0n commented Feb 4, 2025

Hello @jakegut ! Just a reminder to merge this PR at your convenience. Otherwise, it will be merged on February 12.

@jakegut jakegut merged commit 3e21523 into master Feb 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants